Conversation
The scheduled cleanup only saved the bytes it freed, so a run where every item failed looked like a normal run on the Cleaner card. It now saves the failed count and the card adds the existing partial-failure line.
vorssaint
added
ready to merge
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled cleanup only saved how much it freed. When a run could not move anything to the Trash (every item failed), the Cleaner card still said "Last automatic cleanup ." like a normal run, so the failure was invisible unless notifications were on. The run now also saves how many items it left in place, and the card adds the existing "Some items couldn't be moved to the Trash." line when that number is above zero. No new strings; the count stays out of settings backups like the other last-run values.
Verification
./build.sh --test: TESTS OK (61,543 checks). A new contract runs the realfinishRunand the Cleaner card's real last-run line together, and checks that a run which left items in place adds the partial-failure line while a clean run does not../build.sh: compiles and links with 0 warnings.