Repository navigation
fix(privacy): handle file roots in no-split resource imports - #6260
Merged
Merged
Conversation
MaojiaSheng
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Importing a single Markdown file with
--args parse_mode:no_split --processing-mode vectors_onlycan fail withPROCESSING_ERROR: not a directory. Privacy sanitization uses the temporary artifact container's type to choose directory traversal, even when the resolved document root inside that container is a file. Local output stores can silently skip that file instead.Pass the resolved
root_is_fileinto the sanitizer so it reads and sanitizes the document directly before persistence and indexing. Keep the existing directory traversal and file-type artifact fallback.Human Involvement
Related Issue
Follow-up to #6161.
Type of Change
Changes Made
Testing
No new regression tests were added. Validation:
ruff check,ruff format --check, andgit diff --checkpassed.Checklist