fix: derive context_type from URI in index_resource#1346
Merged
qin-ctx merged 1 commit intovolcengine:mainfrom Apr 10, 2026
Merged
fix: derive context_type from URI in index_resource#1346qin-ctx merged 1 commit intovolcengine:mainfrom
qin-ctx merged 1 commit intovolcengine:mainfrom
Conversation
index_resource() always passed the default context_type="resource" to vectorize_directory_meta() and vectorize_file(), even when indexing memory directories (URIs containing /memories/). This caused all records created via the /api/v1/content/reindex endpoint to be tagged as "resource" instead of "memory", breaking stats aggregation (which filters on context_type="memory") and search scoping. Use the existing get_context_type_for_uri() helper to derive the correct context_type from the URI and pass it through to both vectorize_directory_meta() and vectorize_file(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
qin-ctx
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index_resource()always used the defaultcontext_type="resource"when callingvectorize_directory_meta()andvectorize_file(), even for memory directories (/memories/URIs)/api/v1/content/reindexto be tagged as"resource"instead of"memory", breakingStatsAggregator(which filtersEq("context_type", "memory")) and hierarchical search scopingget_context_type_for_uri()helper to derive the correctcontext_typefrom the URIRoot cause
vectorize_fileandvectorize_directory_metaboth default theircontext_typeparameter to"resource". TheSemanticProcessor._process_memory_directory()path correctly hardcodescontext_type="memory", butindex_resource()(used by the reindex API) did not — it relied on the default.Test plan
/api/v1/content/reindexcontext_type="memory"(not"resource")/api/v1/stats/memoriescorrectly counts reindexed records🤖 Generated with Claude Code