Skip to content

fix: fall back to prefix filters for volcengine path scope#1342

Open
haosenwang1018 wants to merge 1 commit intovolcengine:mainfrom
haosenwang1018:fix/volcengine-pathscope-prefix-fallback
Open

fix: fall back to prefix filters for volcengine path scope#1342
haosenwang1018 wants to merge 1 commit intovolcengine:mainfrom
haosenwang1018:fix/volcengine-pathscope-prefix-fallback

Conversation

@haosenwang1018
Copy link
Copy Markdown
Contributor

Summary

  • compile PathScope as a prefix filter in the Volcengine adapter instead of emitting the generic must + para=-d DSL
  • keep the generic PathScope compilation unchanged for other backends
  • add a focused regression test for Volcengine adapter filter compilation

Why

Volcengine backend users reported that target_uri scoped search returns zero results because the cloud backend does not honor the generic para=-d path filter form. This change uses the backend's existing prefix filter support for URI scoping.

Testing

  • ruff check openviking/storage/vectordb_adapters/volcengine_adapter.py tests/storage/test_volcengine_clients.py
  • ruff format --check openviking/storage/vectordb_adapters/volcengine_adapter.py tests/storage/test_volcengine_clients.py
  • git diff --check

Notes

  • Full local pytest validation was blocked by repository-specific AGFS build requirements and optional dependency imports during test bootstrap, so this PR keeps scope tight and locks behavior with a focused adapter regression test.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 95
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants