-
Notifications
You must be signed in to change notification settings - Fork 1.6k
reorg: remove golang depends #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
32efe66
70532a2
f379e09
985d3b4
f6cef18
6011a76
7804344
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,8 @@ | |
| "secret_key": null, | ||
| "endpoint": null, | ||
| "prefix": "", | ||
| "use_ssl": true | ||
| "use_ssl": true, | ||
| "disable_batch_delete": false | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Bug] (blocking) This example now advertises |
||
| } | ||
| } | ||
| }, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] (non-blocking) Please add a regression test that exercises this branch end-to-end.
#1333existed because the old stack silently missed forwarding this flag once already, and this PR rewrites the whole Go path away. Without a test that provesdisable_batch_delete=truereaches the sequential-delete path, this is easy to regress again in a future refactor.