Merged
Conversation
- Add source_name to file upload requests for preserving original filenames - Handle single-directory zip files by using their root directory directly - Support viking://resources as parent directory for imports - Split summarization for resources root imports into individual child items - Add tests for new resource import behaviors
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Improve readability by applying consistent line breaks in test file patches and removing trailing whitespace
MaojiaSheng
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve
add-resourcebehavior when importing intoviking://resources, and preserve stable resource naming for uploaded files and zip archives. This branch fixes root-target imports so they create child resources under the resources root, keeps single-file imports using the original filename stem, and ensures single-root zip archives use the extracted top-level directory name instead of the uploaded.zipfilename.Related Issue
Type of Change
Changes Made
--to viking://resourcesandviking://resources/as imports under the resources root instead of as exact destination URIs, while preserving child URIs for downstream dedup and incremental update flows.source_namefor uploaded files from both Rust and Python clients so single-file imports keep the original filename stem as the resource directory name..zipfilename.viking://resources/<child>target URI.Testing
Test notes:
tests/server/test_api_resources.pytests/misc/test_tree_builder_dedup.pytests/misc/test_media_processor_zip_root.pytests/unit/test_summarizer_resources_root_split.pypytest tests/misc/test_media_processor_zip_root.pyModuleNotFoundError: No module named 'litellm'Checklist
Screenshots (if applicable)
N/A
Additional Notes
Branch diff summary against
main:maincrates/ov_cli/src/client.rsopenviking/parse/parsers/markdown.pyopenviking/parse/tree_builder.pyopenviking/utils/media_processor.pyopenviking/utils/summarizer.pyopenviking_cli/client/http.pytests/misc/test_media_processor_zip_root.pytests/misc/test_tree_builder_dedup.pytests/server/test_api_resources.pytests/unit/test_summarizer_resources_root_split.pyDiff stat against
main: