fix(memory): define config before v2 memory lock retry settings access#1317
Merged
yeshion23333 merged 1 commit intovolcengine:mainfrom Apr 9, 2026
Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
yeshion23333
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a
NameErrorinopenviking/session/compressor_v2.pywhen the v2 memory extraction path enters the lock acquisition retry branch.SessionCompressorV2.extract_long_term_memories()readsconfig.memory.v2_lock_retry_interval_secondsandconfig.memory.v2_lock_max_retries, butconfigwas not defined in that method scope. This change initializes the OpenViking config before those settings areaccessed so v2 memory extraction can retry lock acquisition as intended.
Related Issue
N/A
Type of Change
Changes Made
SessionCompressorV2.extract_long_term_memories()memory.v2_lock_retry_interval_secondsandmemory.v2_lock_max_retriesin the lock retry pathTesting
Checklist
Additional Notes