Skip to content

test: cover context-engine-active recall bypass#1315

Closed
haosenwang1018 wants to merge 3 commits intovolcengine:mainfrom
haosenwang1018:test/cover-context-engine-active-recall-bypass
Closed

test: cover context-engine-active recall bypass#1315
haosenwang1018 wants to merge 3 commits intovolcengine:mainfrom
haosenwang1018:test/cover-context-engine-active-recall-bypass

Conversation

@haosenwang1018
Copy link
Copy Markdown
Contributor

Summary

  • add a real-server plugin test for the OpenClaw compatibility fix path
  • cover the case where the OpenViking context-engine is instantiated before before_prompt_build
  • assert that hook recall is skipped in that case while assemble() still returns OpenViking-backed context

Testing

  • git diff --check

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 95
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx qin-ctx requested a review from Mijamind719 April 9, 2026 03:12
@qin-ctx
Copy link
Copy Markdown
Collaborator

qin-ctx commented Apr 9, 2026

I think we should distinguish recall and assemble here, since they do not overlap in responsibility:

  • before_prompt_build recall is for long-term memory retrieval. It queries OpenViking memory/search with the current query and prepends matched user/agent memories to the prompt.
  • context-engine assemble() is for current-session short-term context reconstruction. It reads OpenViking session context and rebuilds archive summaries / active messages into OpenClaw-consumable messages.

So assemble() is not a replacement for recall, and this PR should not describe them as the same capability.
Thanks for your contribution !

@qin-ctx qin-ctx closed this Apr 9, 2026
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants