Skip to content

fix: skip hook recall when context-engine active#1311

Closed
haosenwang1018 wants to merge 1 commit intovolcengine:mainfrom
haosenwang1018:fix/skip-hook-recall-when-context-engine-active
Closed

fix: skip hook recall when context-engine active#1311
haosenwang1018 wants to merge 1 commit intovolcengine:mainfrom
haosenwang1018:fix/skip-hook-recall-when-context-engine-active

Conversation

@haosenwang1018
Copy link
Copy Markdown
Contributor

Summary

  • skip before_prompt_build auto-recall once the OpenViking context-engine has been instantiated
  • avoid running the legacy hook-based recall path alongside the active context-engine path
  • add a unit test that covers the context-engine-active bypass behavior

Testing

  • git diff --check

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 95
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx qin-ctx closed this Apr 10, 2026
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants