fix: remove debug print statement in bot health check endpoint#1308
Open
sjhddh wants to merge 1 commit intovolcengine:mainfrom
Open
fix: remove debug print statement in bot health check endpoint#1308sjhddh wants to merge 1 commit intovolcengine:mainfrom
sjhddh wants to merge 1 commit intovolcengine:mainfrom
Conversation
|
|
The catch-all exception handler was returning str(exc) directly in the API response, leaking internal filesystem paths, backend error messages, and configuration details to clients (information disclosure). - Replace str(exc) with a static "Internal server error" message - Upgrade logger.warning to logger.exception so the full traceback is preserved in server logs for debugging Closes volcengine#1233
sjhddh
force-pushed
the
fix/remove-debug-print-bot-health
branch
from
69cb3be to
dc815eb
Compare
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a leftover
print()debug statement introduced in #1285 (merged 2026-04-07) when the bot proxy router was added.The offending line in
openviking/server/routers/bot.py(was line 53):This writes the internal bot service URL to stdout on every health check request. Every other log call in this file uses the
loggerobject — thisprint()was clearly a debug leftover that slipped through.Change
Single line deletion — no behavior change, no functional impact.
- print(f"url={f'{bot_url}/bot/v1/health'}") # Forward to Vikingbot OpenAPIChannel health endpoint