fix: correct grammar and typos in code comments#1062
Conversation
Signed-off-by: Anirudh <2410030013@klh.edu.in>
Signed-off-by: Anirudh <2410030013@klh.edu.in>
There was a problem hiding this comment.
Pull request overview
This PR cleans up minor grammar and typo issues in code comments.
Changes:
- Updates a metrics helper attribution comment from “refer to” to “refers to”.
- Attempts to clean up spacing in the
ModelRouteSpec.ModelNamecomment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pkg/kthena-router/backend/metrics/metrics.go |
Corrects grammar in a function comment. |
pkg/apis/networking/v1alpha1/modelroute_types.go |
Updates a model route field comment, but introduces a duplicated comment marker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request includes minor documentation updates and typo fixes. In modelroute_types.go, a comment regarding the ModelName field was updated, but it introduced a double-slash typo and incorrectly referenced ModelAdapters instead of LoraAdapters. In metrics.go, a grammatical error in a function comment was corrected. The feedback identifies the typo and the naming inconsistency in the API documentation, providing a specific code suggestion for correction.
Signed-off-by: Anirudh <2410030013@klh.edu.in>
Signed-off-by: Anirudh <2410030013@klh.edu.in>
|
@FAUST-BENCHOU: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix minor grammar and typos in code comments