fix: use controller owner refs for modelbooster children#1054
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the construction of OwnerReferences across several files by utilizing the utils.NewModelOwnerRef helper function. This change standardizes the creation of owner references for ModelBooster and ensures that the blockOwnerDeletion and controller fields are correctly set to true, as reflected in the updated test expectations. I have no feedback to provide.
Signed-off-by: pm-ju <pmdevops29@gmail.com>
pm-ju
force-pushed
the
fix-modelbooster-child-controller-ownerrefs
branch
2 times, most recently
from
bfeecfe to
ba5b698
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug
ModelBooster-generated ModelServing and ModelRoute resources were hand-building ownerReferences without controller=true and blockOwnerDeletion=true.
Other ModelBooster child resources already use utils.NewModelOwnerRef, so this makes ownership metadata consistent and improves Kubernetes GC/controller ownership semantics.
Verification:
git diff --check
git diff --cached --check