Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert Icon #976

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Alert Icon #976

merged 3 commits into from
Feb 4, 2025

Conversation

gerouvi
Copy link
Collaborator

@gerouvi gerouvi commented Feb 3, 2025

changed alert success green, icon centred and gap between icon and text.

closes #893

@gerouvi gerouvi requested a review from elboletaire February 3, 2025 09:18
Copy link

github-actions bot commented Feb 3, 2025

@github-actions github-actions bot temporarily deployed to pull request February 3, 2025 09:19 Inactive
Copy link

github-actions bot commented Feb 3, 2025

@github-actions github-actions bot temporarily deployed to pull request February 3, 2025 09:19 Inactive
@jpaulet jpaulet mentioned this pull request Feb 4, 2025
@github-actions github-actions bot temporarily deployed to pull request February 4, 2025 11:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 4, 2025 11:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 4, 2025 15:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 4, 2025 15:23 Inactive
@elboletaire elboletaire merged commit 9cfcf72 into develop Feb 4, 2025
3 checks passed
@elboletaire elboletaire deleted the b/alerts-893 branch February 4, 2025 15:29
jpaulet added a commit that referenced this pull request Feb 11, 2025
* fix: Alert icon spacing (#976)

* changed alert success green, icon centred and gap between icon and text, closes #893

* refs #893 There's no need for a wrapping box...

---------

Co-authored-by: Òscar Casajuana <[email protected]>

* fix: proper body background color (#979)

* fix: subscription should be protected for non org members (#977)

* fix: revert dashboard route change

* fix: signup form not properly reset after signup

closes #953

* review 1.0

* fixed issue margin between sections

* fix issue linter

* projects btn

* fixed accesibility issues

* fixed issue responsive

---------

Co-authored-by: gerouvi <[email protected]>
Co-authored-by: Òscar Casajuana <[email protected]>
Co-authored-by: Gerard <[email protected]>
elboletaire added a commit that referenced this pull request Feb 12, 2025
* Improved layouts in the landing page, added new components, unified width to max 1600px, added all the subpages into the section box, improved navbar lang and switch. Header and footer to 100%. Added more margins to sections, created new "Projects" section, removed unnecessary elements, etc.

* Reduced vocdoni logo size

* Translations and added FAQ (from 1 to 45)

* F/landing review (#984)

* fix: Alert icon spacing (#976)

* changed alert success green, icon centred and gap between icon and text, closes #893

* refs #893 There's no need for a wrapping box...

---------

Co-authored-by: Òscar Casajuana <[email protected]>

* fix: proper body background color (#979)

* fix: subscription should be protected for non org members (#977)

* fix: revert dashboard route change

* fix: signup form not properly reset after signup

closes #953

* review 1.0

* fixed issue margin between sections

* fix issue linter

* projects btn

* fixed accesibility issues

* fixed issue responsive

---------

Co-authored-by: gerouvi <[email protected]>
Co-authored-by: Òscar Casajuana <[email protected]>
Co-authored-by: Gerard <[email protected]>

---------

Co-authored-by: gerouvi <[email protected]>
Co-authored-by: Òscar Casajuana <[email protected]>
Co-authored-by: Gerard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error alerts are wrong
2 participants