feat(ui): add cookie consent banner #1011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elboletaire
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Overall looks ok, but needs adding i18n. Use the Trans component and the useTranslation hook in order to add translatable strings.
After converting all the translatable strings to use the component (or the hook), run yarn translations to extract them all and commit the locales files.
There's no need to actually translate them to spanish and catalan, we'll do that 😊
Thanks for your collaboration 😃
|
|
||
| const CookieBanner = () => { | ||
| return ( | ||
| <div> |
There was a problem hiding this comment.
Is this div here for any special reason? I think it could perfectly be omitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #986