-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule2 #146
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Andreas Hubel <[email protected]>
Signed-off-by: Andreas Hubel <[email protected]>
@toto Sollen wir die kompletten Services hierher in schedule2 mit übernehmen?
|
Not all pick: that's historical baggage. How about
|
{ | ||
"guid": "3dc5daf5-ba21-4577-97e4-fb6e4b5d40e1", | ||
"name": "Art & Beauty", | ||
"colors": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're defining multiple colours, we should add a field for preferred colour scheme so apps know which to select in case there's no user choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An additional question would be if it really makes sense to have different colours for light and dark mode here, if the Conference
only defines a primary
and background
colour.
"type": "lecturehall", | ||
"stream_id": "s1", | ||
"capacity": 3025, | ||
"description": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as with track colours, we should have a field for the "default" language.
"type": ["string", "null", "object"] | ||
}, | ||
"description": { | ||
"type": ["string", "null", "object"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm slightly in favour to removing the string
option here and to only allow objects with localized strings. This will make it easier for apps that try to parse the schedule.
breaking changes to the schedule.json schema, thereby a own new version called
schedule2
, see 6632bbb for an comparison between the formatspublic_name
,daysCount
,timeslot_duration
, …color
->colors
to allow multiple color values e.g. for light an dark – and to be uniform to same attribute on Conferenceguid
fieldAccept
header"string"
to object{"en": "string", "de": "string"}
, but the old way is still allowedday_start
andday_end
get's unified tostart
andend
Participant
and has arole
attributelogo
andavatar
are now an object{"url": "uri-string"}
instead of"uri-string"
start
andend
instead ofdate
andduration
, fixing Clarify duration spec #129TODOs