govc: Move govc commands into cli pkg #3619
Conversation
akutz
force-pushed
the
feature/app
branch
2 times, most recently
from
d8d4ee9
to
3b6eb5c
Compare
akutz
changed the title
There was a problem hiding this comment.
Thanks @akutz
Also need to update: https://github.com/vmware/govmomi/blob/main/.goreleaser.yml#L20
Can we leave emacs in the govc directory? That'll avoid breaking this: https://github.com/melpa/melpa/blob/master/recipes/govc
Maybe keep examples/lib/ssh.sh under govc too. Or we could just remove it, the embedded examples we have now are more useful.
This patch refactors the `govc` command so all of its actual logic and commands are located in the root GoVmomi module under the `cli` package. The `govc` package may still be used to build, install, and test `govc`, but this change allows others to import the pieces of `govc` without being beholden to the `govc` module's Golang version. Signed-off-by: akutz <[email protected]> BREAKING: All packages `./govc/*` (except `./govc/test`) have been relocated under the `./cli` package.
Done, done, and done! |
Description
This patch refactors the
govccommand so all of its actual logic and commands are located in the root GoVmomi module under theclipackage. Thegovcpackage may still be used to build, install, and testgovc, but this change allows others to import the pieces ofgovcwithout being beholden to thegovcmodule's Golang version.All packages
./govc/*(except./govc/test) have been relocated under the./clipackage.Closes:
NAHow Has This Been Tested?
make installmake testmake govc-testGuidelines
Please read and follow the
CONTRIBUTIONguidelines of this project.