govc: Add an unreleased folder.place command for PlaceVMsXCluster #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbeard
force-pushed
the
govc-folder-placevmsxcluster
branch
from
09ecea6
to
024b95b
Compare
dougm
previously approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Thanks @derekbeard , looks good, some minor requests and suggestions.
govc/folder/place.go
Outdated
| } | ||
|
|
||
| if vm == nil { | ||
| return errors.New("please specify a vm") |
There was a problem hiding this comment.
Can just return flag.ErrHelp here, outputs the command -h help.
govc/folder/place.go
Outdated
| ResourcePools: refs, | ||
| PlacementType: cmd.placementType, | ||
| VmPlacementSpecs: vmPlacementSpecs, | ||
| HostRecommRequired: &t, |
There was a problem hiding this comment.
We also have types.NewBool(true) helper.
govc/folder/place.go
Outdated
| cmd.OutputFlag, ctx = flags.NewOutputFlag(ctx) | ||
| cmd.OutputFlag.Register(ctx, f) | ||
|
|
||
| f.Var(&cmd.resourcePool, "rp", "Resource Pools to use for placement.") |
There was a problem hiding this comment.
Can we use "pool" for the flag name as we do in other commands?
govc/folder/place.go
Outdated
| for _, fault := range pfault.Faults { | ||
| err := res.placementFault(w, pfault, &fault) | ||
| if err != nil { | ||
| return nil |
There was a problem hiding this comment.
Oops, late night coding. Ack.
govc/folder/place.go
Outdated
| if reconfigureAction, ok := action.(*types.ClusterClusterReconfigurePlacementAction); ok { | ||
| err := res.reconfigurePlacementAction(w, pinfo, reconfigureAction) | ||
| if err != nil { | ||
| return nil |
| PlacementType: string(types.PlaceVmsXClusterSpecPlacementTypeRelocate), | ||
| ResourcePools: test.poolMoRefs, | ||
| PlacementType: string(types.PlaceVmsXClusterSpecPlacementTypeRelocate), | ||
| HostRecommRequired: &truebool, |
govc/folder/place.go
Outdated
| vimClient *vim25.Client | ||
| soapClient *soap.Client | ||
| ctx context.Context | ||
| dc *flags.DatacenterFlag |
govc/folder/place.go
Outdated
| type placementResult struct { | ||
| Result *types.PlaceVmsXClusterResult `json:"result,omitempty"` | ||
| vimClient *vim25.Client | ||
| soapClient *soap.Client |
There was a problem hiding this comment.
Looks like soapClient field is unused
derekbeard
force-pushed
the
govc-folder-placevmsxcluster
branch
from
024b95b
to
0920911
Compare
This change adds an unreleased govc command to exercise the cross-cluster placement engine via folder.PlaceVmsXCluster. This command is limited to supporting the only a relocate placement type but will be extended to support createAndPowerOn and reconfigure in the future. Bats tests are added to perform basic validation of the new command. This change also fixes the PlaceVMSXCluster action types to match the types returned by the VIM API, specifically: ClusterReconfigurePlacementAction => ClusterClusterReconfigurePlacementAction ClusterRelocatePlacementAction => ClusterClusterRelocatePlacementAction This change also improves the simulator to return the appropriate action types based off of the placementType and improves the tests to validate the action type. Testing Done: ./govc/test/folder.bats go test -v -count=1 ./simulator -run TestPlaceVmsXClusterCreateAndPowerOn go test -v -count=1 ./simulator -run TestPlaceVmsXClusterReconfigure go test -v -count=1 ./simulator -run TestPlaceVmsXClusterRelocate
derekbeard
force-pushed
the
govc-folder-placevmsxcluster
branch
from
0920911
to
831b722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an unreleased govc command to exercise the cross-cluster placement engine via folder.PlaceVmsXCluster. This command is limited to supporting the only a relocate placement type but will be extended to support createAndPowerOn and reconfigure in the future. Bats tests are added to perform basic validation of the new command.
This change also fixes the PlaceVMSXCluster action types to match the types returned by the VIM API, specifically:
ClusterReconfigurePlacementAction => ClusterClusterReconfigurePlacementAction ClusterRelocatePlacementAction => ClusterClusterRelocatePlacementAction
This change also improves the simulator to return the appropriate action types based off of the placementType and improves the tests to validate the action type.
Testing Done:
./govc/test/folder.bats
go test -v -count=1 ./simulator -run TestPlaceVmsXClusterCreateAndPowerOn
go test -v -count=1 ./simulator -run TestPlaceVmsXClusterReconfigure
go test -v -count=1 ./simulator -run TestPlaceVmsXClusterRelocate