-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vrotest,vrotsc] (#461) Make unit test setup configurable and add Jasmine and Jest default configuration #465
[vrotest,vrotsc] (#461) Make unit test setup configurable and add Jasmine and Jest default configuration #465
Conversation
…rk configuration.
… tests framework.
…onfiguration per package type for configurable unit test framework.
Reading details from the project pom file, generating the needed files and storing them in the project root directory for persistent unit tests configuration.
It will remain a part of the build tools runtime process, not the triggered tests process.
Added some details for the unit test framework configuration.
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
typescript/vrotest/src/build.ts
Outdated
const setupFramework = hasCustomTestsConfig | ||
? undefined | ||
: ( | ||
flags.testFrameworkPackage === "jest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering whether it is worth converting this logic to a switch case and putting it in a function so that it is easier to extend down the line if we introduce more frameworks.
that being said, I don't think that we will introduce another test framework soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even better we could convert that to a factory. I was thinking of changing this to a factory either way so I could definitely do that, I didn't because I can't see introducing support for another framework as well and don't want to add more complexity to the code if not necessary... So I would appreciate your point of view as well and we can apply changes as we decide collectively :)
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
7 similar comments
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
84137de
to
6f67b3f
Compare
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Plamen Boychev <[email protected]>
Signed-off-by: Plamen Boychev <[email protected]>
6f67b3f
to
af02789
Compare
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Plamen Boychev <[email protected]>
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@pboychev-bcom, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
NOTE:
Will update the description later. Opening the PR for early peer reviews.
Description
Checklist
Fixed #XXX -
orClosed #XXX -
prefix to auto-close the issueTesting
Release Notes
Related issues and PRs