🌱 Use VAPI ActivationID with DeployOVF #802
Merged
+37
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the DeployOVF call to use the VAPI activationID header. The value is set to the VM's instance UUID. This means the vim.Task that Content Library spawns to track the actual DeployOVF operation will have its activationId field set to the value of vm.spec.instanceUUID. Thus VM Operator can find and track the task, even though the DeployOVF call is blocking and does not return a task ID.
Minimum allowed line rate is |
bryanv
approved these changes
Nov 14, 2024
Thanks. I remember. The period of time depends on the API implementation as some create the task immediate and others do not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch updates the DeployOVF call to use the VAPI activationID header. The value is set to the VM's instance UUID. This means the vim.Task that Content Library spawns to track the actual DeployOVF operation will have its activationId field set to the value of vm.spec.instanceUUID. Thus VM Operator can find and track the task, even though the DeployOVF call is blocking and does not return a task ID.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: