🌱 Move instancestorage helpers to vmopv1util #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanv
force-pushed
the
bryanv/move-instancestorage-under-util
branch
from
0a2ee6b
to
b885d0c
Compare
dilyar85
approved these changes
Nov 13, 2024
| @@ -1,7 +1,7 @@ | |||
| // Copyright (c) 2021 VMware, Inc. All Rights Reserved. | |||
There was a problem hiding this comment.
Nit: outdated copyright header
bryanv
force-pushed
the
bryanv/move-instancestorage-under-util
branch
from
b885d0c
to
f7f959a
Compare
Doesn't need to be in old provider anymore, and makes more sense to be under pkg/util/vmopv1 in our current hierarchy.
bryanv
force-pushed
the
bryanv/move-instancestorage-under-util
branch
from
f7f959a
to
94ea902
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This doesn't need to be in old provider anymore
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: