Add Design for Allowing Instance-Level Resource Status Restore #8403
+111
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-pampattiwar
force-pushed
the
status-restore-cr-design
branch
from
0a2eb16
to
3a2d71c
Compare
Signed-off-by: Shubham Pampattiwar <[email protected]> add changelog file Signed-off-by: Shubham Pampattiwar <[email protected]> typo fix Signed-off-by: Shubham Pampattiwar <[email protected]>
shubham-pampattiwar
force-pushed
the
status-restore-cr-design
branch
from
3a2d71c
to
d0621c7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8403 +/- ##
==========================================
- Coverage 58.96% 58.95% -0.02%
==========================================
Files 367 367
Lines 38895 38902 +7
==========================================
Hits 22933 22933
- Misses 14500 14507 +7
Partials 1462 1462 ☔ View full report in Codecov by Sentry. |
kaovilai
reviewed
Nov 13, 2024
| 1. Controller managing specific Resources | ||
| - A resource controller identifies that a specific instance of a resource should have its status restored due to particular dependencies | ||
| - The controller automatically sets the `velero.io/restore-status: true` annotation on the resource. | ||
| - During restore, Velero restores the status of this instance, while leaving other resources unaffected. |
There was a problem hiding this comment.
Will velero also annotate that it had restored the status on the resource? That would help with debugging why a resource is a certain status if a controller did not expect its resouce status to be modified by other controllers (velero).
There was a problem hiding this comment.
I think current source of truth is the Restore CR spec as well as the label on instance, and IMHO that is sufficient to indicate for why the status was restored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Design for #8204
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.