-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tracking for deleted namespace status check in restore flow #8233
base: main
Are you sure you want to change the base?
Conversation
For - #8234 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8233 +/- ##
==========================================
- Coverage 59.15% 58.98% -0.18%
==========================================
Files 367 368 +1
Lines 30777 38929 +8152
==========================================
+ Hits 18206 22962 +4756
- Misses 11113 14505 +3392
- Partials 1458 1462 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add changelog and run linter.
d617a73
to
e6a32e8
Compare
Given we've reached FC and this may impact the restore flow, let's hold this one until the branch is cut for v1.15 |
72d3b56
to
c63dd9b
Compare
Signed-off-by: sangitaray2021 <[email protected]> fixed unittest Signed-off-by: sangitaray2021 <[email protected]> refactored tracker execution and caller Signed-off-by: sangitaray2021 <[email protected]> added change log Signed-off-by: sangitaray2021 <[email protected]> Author: sangitaray2021 <[email protected]> Author: sangitaray2021 <[email protected]> Date: Thu Sep 19 02:26:14 2024 +0530 Signed-off-by: sangitaray2021 <[email protected]>
c63dd9b
to
d147cba
Compare
Signed-off-by: sangitaray2021 <[email protected]>
@kaovilai can you help review the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC from reviewing, this change reduce potential duplicate await on if namespace exists (wait for 10 min polling)
to just one instance per restore. Is that correct?
It's not meant to add polling until deletion is complete to resume some other process?
yes thats correct. We are reducing duplicate wait by caching the namespace which is under deletion. |
Signed-off-by: sangitaray2021 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: sangitaray2021 <[email protected]>
@reasonerjt can you review this PR now given 1.15 is cut? |
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #8234
Please indicate you've done the following:
make new-changelog
) or comment/kind changelog-not-required
on this PR.site/content/docs/main
.