You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We noticed that starting from v0.56.17 / v0.57.x, the behaviour of sonobuoy wait changed - In the "before" version, it will wait (as expected) until tests have finished or a certain timeout has been reached:
$ time ./sonobuoy wait
^C
./sonobuoy wait 0.04s user 0.01s system 0% cpu 7.950 total
In the "after" version, sonobuoy wait immediately returns with the following error:
$ time sonobuoy wait
ERRO[0000] error attempting to run sonobuoy: waiting for run to finish: context deadline exceeded
sonobuoy wait 0.03s user 0.04s system 18% cpu 0.372 total
The command only works if you pass the --wait flag, which seems like an odd "default usage".
This can be reproduced by switching between the v0.56.16 and the v0.56.17 git tag, building the binary and comparing behaviour of the command.
What did you expect to happen:
sonobuoy wait continues to exhibit consistent behaviour between patch releases.
Anything else you would like to add:
I was wondering if f5aa6ba was the culprit of this, but there isn't anything obvious in this commit that would cause this.
embik
changed the title
Behaviour of sonobuoy wait changed from v0.56.16 to v0.56.17, requires --wait flag nowsonobuoy wait requires --wait flag to be functional
Dec 21, 2023
What steps did you take and what happened:
We noticed that starting from v0.56.17 / v0.57.x, the behaviour of
sonobuoy wait
changed - In the "before" version, it will wait (as expected) until tests have finished or a certain timeout has been reached:In the "after" version,
sonobuoy wait
immediately returns with the following error:The command only works if you pass the
--wait
flag, which seems like an odd "default usage".This can be reproduced by switching between the
v0.56.16
and thev0.56.17
git tag, building the binary and comparing behaviour of the command.What did you expect to happen:
sonobuoy wait
continues to exhibit consistent behaviour between patch releases.Anything else you would like to add:
I was wondering if f5aa6ba was the culprit of this, but there isn't anything obvious in this commit that would cause this.
Environment:
kubectl version
):v1.27.6
/etc/os-release
): n/aThe text was updated successfully, but these errors were encountered: