Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to 1.21.5 and machine-controller to v1.58.1 #2988

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Update Go to 1.21.5 and machine-controller to v1.58.1 #2988

merged 2 commits into from
Dec 21, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Dec 19, 2023

What this PR does / why we need it:

Update Go to 1.21.5 and machine-controller to v1.58.1.

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

- KubeOne is now built with Go 1.21.5
- Update machine-controller to v1.58.1

Documentation:

NONE

/assign @kron4eg

@xmudrii
Update Go to 1.21.5
c14f808 
Signed-off-by: Marko Mudrinić <[email protected]>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 19, 2023
kron4eg
kron4eg approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e785cec5297659491f0313f58893444c46061625

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2023
@xmudrii xmudrii mentioned this pull request Dec 19, 2023
Merged
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kron4eg kron4eg removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2023
@kron4eg
Copy link
Member

kron4eg commented Dec 19, 2023

removed approve, to avoid useless tests rerun as they definitely fail

@embik
Copy link
Member

embik commented Dec 20, 2023

See #2989 (comment) and comments above, I think sonobuoy wait needs to be sonobuoy wait --wait. I guess this behaviour changed between sonobuoy 0.56 and 0.57 without being intended and/or documented.

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@kron4eg
Copy link
Member

kron4eg commented Dec 21, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6deb564fc3c026bbf8f78a3b24eeba53e640ee06

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 46fd3d4 into main Dec 21, 2023
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Dec 21, 2023
@kubermatic-bot kubermatic-bot deleted the go-1.21.5 branch December 21, 2023 08:37
@embik
Copy link
Member

embik commented Dec 21, 2023

Note: I raised vmware-tanzu/sonobuoy#1954 upstream.

@xmudrii xmudrii added the backport-complete Denotes a PR or issue which has been fully backported to all required release branches. label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@xmudrii @kubermatic-bot @kubermatic-triage-bot @kron4eg @embik