upgrade cyclonedx to v0.7.0 #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scothis
reviewed
Oct 27, 2022
webhook/go.mod
Outdated
| @@ -27,3 +27,5 @@ require ( | |||
| sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 // indirect | |||
| sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/CycloneDX/cyclonedx-go => github.com/CycloneDX/cyclonedx-go v0.6.0 | |||
There was a problem hiding this comment.
what does this do? Looks like a no-op?
scothis
reviewed
Oct 27, 2022
go.mod
Outdated
| @@ -123,3 +123,5 @@ require ( | |||
| sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 // indirect | |||
| sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/CycloneDX/cyclonedx-go => github.com/CycloneDX/cyclonedx-go v0.6.0 | |||
There was a problem hiding this comment.
I'd expect to see a replace for the webhook module here instead. Something like:
Suggested change
| replace github.com/CycloneDX/cyclonedx-go => github.com/CycloneDX/cyclonedx-go v0.6.0 | |
| replace github.com/vmware-tanzu/cartographer-conventions/webhook => ./webhook |
It would also be nice to pull this up to the top so that it's not burried under the indirect dependencies.
katmutua
changed the title
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
=======================================
Coverage 69.88% 69.88%
=======================================
Files 17 17
Lines 943 943
=======================================
Hits 659 659
Misses 263 263
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
katmutua
added
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request