Skip to content
This repository was archived by the owner on Mar 24, 2022. It is now read-only.

Conversation

@matthewryanscott
Copy link

Prior to this patch, you'd get the following traceback if you didn't specify a 'minion' key in an entry in /etc/salt/cloud.profiles:

$ sudo salt-cloud -m /etc/salt/cloud.map
[INFO ] salt-cloud starting
[INFO ] Applying map from '/etc/salt/cloud.map'.
[ERROR ] There was a query error: 'minion'
Traceback (most recent call last):
File "/opt/salt-cloud/src/salt-cloud/saltcloud/cli.py", line 273, in run
dmap = mapper.map_data()
File "/opt/salt-cloud/src/salt-cloud/saltcloud/cloud.py", line 1102, in map_data
if 'grains' in nodedata['minion']:
KeyError: 'minion'

Prior to this patch, you'd get the following traceback if you didn't specify a 'minion' key in an entry in /etc/salt/cloud.profiles:

$ sudo salt-cloud -m /etc/salt/cloud.map
[INFO    ] salt-cloud starting
[INFO    ] Applying map from '/etc/salt/cloud.map'.
[ERROR   ] There was a query error: 'minion'
Traceback (most recent call last):
  File "/opt/salt-cloud/src/salt-cloud/saltcloud/cli.py", line 273, in run
    dmap = mapper.map_data()
  File "/opt/salt-cloud/src/salt-cloud/saltcloud/cloud.py", line 1102, in map_data
    if 'grains' in nodedata['minion']:
KeyError: 'minion'
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 872e6e3 on 11craft:issue-701 into d37fdb0 on saltstack:develop.

@techhat
Copy link
Contributor

techhat commented Nov 7, 2013

@s0undt3ch, what are your thoughts on this?

@s0undt3ch
Copy link
Contributor

Still need to test the provided configuration to see if I reproduce. This fixes the problem but we need to make sure it's not something deeper in the code.

@techhat
Copy link
Contributor

techhat commented Nov 10, 2013

@gldnspud, I'm sorry that we didn't get this addressed before we got salt-cloud merged into Salt. Even though it is no longer physically possible to merge code into Salt Cloud from this repo, I'm going to leave this in until we can get it addressed in the new salt.cloud location. If we do end up using this change, we'll be sure to credit you appropriately, of course.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants