This repository has been archived by the owner on Mar 15, 2022. It is now read-only.
Use go modules, upgrade dependencies, add skaffold.dev #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 19, 2019 16:08
Signed-off-by: Jorik van der Werf <[email protected]>
Signed-off-by: Jorik van der Werf <[email protected]>
Signed-off-by: Jorik van der Werf <[email protected]>
…fold Signed-off-by: Jorik van der Werf <[email protected]>
Signed-off-by: Jorik van der Werf <[email protected]>
Signed-off-by: Jorik van der Werf <[email protected]>
|
go 1.13, we have module mirror, may be we should ditch vendoring all together? |
vigith
added a commit
to vigith/eventrouter
that referenced
this pull request
Sep 10, 2019
* Use go .12 and use modules instead of dep * Use a multistage Dockerfile to build/test the project * Updated the versions of: * Go: v1.9 -> v1.12.x * Alpine Linux: v3.6 -> v3.9. * Go dependencies, for example: k8s.io/client_go v5.0.0 -> v12.0.0 Signed-off-by: Vigith Maurice <[email protected]>
vigith
added a commit
to vigith/eventrouter
that referenced
this pull request
Sep 11, 2019
most of vmware-archive#80 (took Dockerfile, Makefile and go.mod)
Closed
vigith
added a commit
to vigith/eventrouter
that referenced
this pull request
Sep 11, 2019
* Use go .12 and use modules instead of dep * Use a multistage Dockerfile to build/test the project * Updated the versions of: * Go: v1.9 -> v1.12.x * Alpine Linux: v3.6 -> v3.9. * Go dependencies, for example: k8s.io/client_go v5.0.0 -> v12.0.0 * version to 0.3 (from 0.2) Signed-off-by: Vigith Maurice <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @chuckha & @timothysc,
This pull requests is based on the work as described in this comment: #77 (comment)
What's included, in short:
I tried to find an Alpine Linux 3.9 & Go 1.12.x on gcr.io/heptio-images/...., but couldn't find any. So I'm using the publicly available ones now.
I've also added a skaffold.yaml (using skaffold) to easily run the EventRouter in your local Kubernetes cluster using the already provided eventrouter.yaml. I hope this is ok.
I understand that the size of this PR can be quite concerning, but it actually deletes a lot more than it adds.
I hope we can find a way to merge these changes into the upstream branch, as we would like to contribute to your repository!
If these changes will be accepted, I will create a new PR soon that actually contributes the new sink.
Thanks for the cool open source project!
Jorik