Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Collect gauge events #62

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

caruccio
Copy link

Hey. Does it makes any sense for you?

Signed-off-by: Mateus Caruccio <[email protected]>
@rosskukulinski
Copy link
Contributor

@caruccio Thanks for submitting this! @timothysc do you have a few minutes to take a look?

On first glance, I don't think Gauge is the appropriate metric. I think a better metric would of type Counter, that we increment for every event. This will allow Prometheus to calculate the total events ever as well as the rate of new events for any given time period.

Copy link
Contributor

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@johnSchnake
Copy link
Contributor

@caruccio Could you sign your commits? If you can do that (and ideally rebase onto master) I can merge. I can always merge master into your branch via the UI but would prefer the commits just be your own unless you find it easier to have me do that part.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants