-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[CI][Intel Gaudi][vllm-Plugin]Add CI for hpu-plugin-v1-test #20196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][Intel Gaudi][vllm-Plugin]Add CI for hpu-plugin-v1-test #20196
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @xuechendi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new continuous integration (CI) test specifically designed for the Intel Gaudi HPU plugin (v1) within the vLLM project. The test is implemented as a Buildkite script that containerizes the HPU environment, builds vLLM with HPU support, and executes basic offline inference examples, including a tensor-parallel configuration, to validate functionality. A minor adjustment was also made to an example script to ensure clean exits in the CI context.
Highlights
- New CI Script for Intel Gaudi: A new Buildkite CI script (
run-hpu-plugin-v1-test.sh
) has been added to automate testing of the vLLM HPU plugin (v1) on Intel Gaudi hardware. - Dockerized HPU Testing Environment: The CI script builds a Docker image that sets up the necessary HPU environment, installs vLLM with HPU support, and prepares the workspace for running tests.
- Basic and Tensor Parallel Tests: The CI includes two primary tests: one for basic offline inference using the
facebook/opt-125m
model and another for the same model with a tensor-parallel size of 2, ensuring core functionality and scaling. - Python Script Exit Handling: The
examples/offline_inference/basic/generate.py
script was modified to explicitly callos._exit(0)
at the end, ensuring a clean and immediate exit from the Python process, which is often beneficial in automated CI environments.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new CI test for the Intel Gaudi HPU plugin. The review suggests pinning the vllm-gaudi dependency in the CI script for stability and documenting the use of os._exit(0)
in the example script, making it conditional if possible.
18a18e6
to
f6c5a5f
Compare
@seemethere @huydhn @kzawora-intel , please help to review, I wang to update HPU CI to use plugin now. |
f6c5a5f
to
0966821
Compare
Signed-off-by: Chendi Xue <[email protected]>
3c7fa6f
to
46a070f
Compare
@DarkLight1337 @seemethere , may you approve this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
…ject#20196) Signed-off-by: Chendi Xue <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Add a new test for intel-hpu-plugin-v1
This will help to monitor in-tree changes might fail vllm-plugin, regarding to
#19161
once this PR gets merged, vllm-project/ci-infra#116 will help notification to Intel-ci-collab channel for failing notification
Test Plan
Test Result
(Optional) Documentation Update