Skip to content

[CI][Intel Gaudi][vllm-Plugin]Add CI for hpu-plugin-v1-test #20196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

xuechendi
Copy link
Contributor

@xuechendi xuechendi commented Jun 27, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • [x ] The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Add a new test for intel-hpu-plugin-v1
This will help to monitor in-tree changes might fail vllm-plugin, regarding to
#19161

once this PR gets merged, vllm-project/ci-infra#116 will help notification to Intel-ci-collab channel for failing notification

Test Plan

Test Result

(Optional) Documentation Update

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @xuechendi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new continuous integration (CI) test specifically designed for the Intel Gaudi HPU plugin (v1) within the vLLM project. The test is implemented as a Buildkite script that containerizes the HPU environment, builds vLLM with HPU support, and executes basic offline inference examples, including a tensor-parallel configuration, to validate functionality. A minor adjustment was also made to an example script to ensure clean exits in the CI context.

Highlights

  • New CI Script for Intel Gaudi: A new Buildkite CI script (run-hpu-plugin-v1-test.sh) has been added to automate testing of the vLLM HPU plugin (v1) on Intel Gaudi hardware.
  • Dockerized HPU Testing Environment: The CI script builds a Docker image that sets up the necessary HPU environment, installs vLLM with HPU support, and prepares the workspace for running tests.
  • Basic and Tensor Parallel Tests: The CI includes two primary tests: one for basic offline inference using the facebook/opt-125m model and another for the same model with a tensor-parallel size of 2, ensuring core functionality and scaling.
  • Python Script Exit Handling: The examples/offline_inference/basic/generate.py script was modified to explicitly call os._exit(0) at the end, ensuring a clean and immediate exit from the Python process, which is often beneficial in automated CI environments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Jun 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new CI test for the Intel Gaudi HPU plugin. The review suggests pinning the vllm-gaudi dependency in the CI script for stability and documenting the use of os._exit(0) in the example script, making it conditional if possible.

@xuechendi xuechendi force-pushed the add_hpu_plugin_v1_ci branch 2 times, most recently from 18a18e6 to f6c5a5f Compare June 27, 2025 19:47
@xuechendi
Copy link
Contributor Author

@seemethere @huydhn @kzawora-intel , please help to review, I wang to update HPU CI to use plugin now.

@xuechendi xuechendi force-pushed the add_hpu_plugin_v1_ci branch from f6c5a5f to 0966821 Compare June 27, 2025 19:56
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 30, 2025
@xuechendi xuechendi force-pushed the add_hpu_plugin_v1_ci branch from 3c7fa6f to 46a070f Compare June 30, 2025 23:15
@xuechendi
Copy link
Contributor Author

@DarkLight1337 @seemethere , may you approve this PR.
Now this PR will update hpu script only
This PR is very important for us to keep track any new coming PR which might introduce changes in common data structures such as scheduler_output and breaks out-of-tree vllm-gaudi.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 1, 2025 03:09
@DarkLight1337 DarkLight1337 merged commit a2f14dc into vllm-project:main Jul 1, 2025
50 checks passed
CSWYF3634076 pushed a commit to CSWYF3634076/vllm that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants