Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Refactor KVCacheConfig #14079

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

heheda12345
Copy link
Collaborator

@heheda12345 heheda12345 commented Mar 1, 2025

This PR makes the following changes to KVCacheConfig

  1. change the meaning of KVCacheSpec from the spec of the model to the spec of one layer
  2. KVCacheConfig class:
    1. change the concept of "group" to "virtual_layer"
    2. save the kv_cache_spec for each virtual_layer instead of each layer
  3. The logic to make the same KVCacheConfig for all workers (EngineCore._initialize_kv_caches). Change it into 3 steps:
    1. get the available memory of each worker independently
    2. get the kv_cache_config for each worker independently
    3. adjust the kv_cache_config for all workers to make them the same, including assigning the same num_blocks and the same virtual layers (make_kv_cache_configs_consistent)

Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
Copy link

github-actions bot commented Mar 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants