Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune release tag to support release candidates #14064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tune release tag to support release candidates #14064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ name: Create Release
on:
push:
tags:
- v*
# NOTE: Binary build pipelines should only get triggered on release candidate builds
# Release candidate tags look like: v0.7.3-rc1
- v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+

# Needed to create release and upload assets
permissions:
Expand Down Expand Up @@ -39,7 +41,7 @@ jobs:
const script = require('.github/workflows/scripts/create_release.js')
await script(github, context, core)

# NOTE(simon): No longer build wheel using Github Actions. See buildkite's release workflow.
# NOTE(simon): No longer build wheel using Github Actions. See buildkite's release workflow.
# wheel:
# name: Build Wheel
# runs-on: ${{ matrix.os }}
Expand Down