-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1][Core] FlashInfer attention backend for V1 #14061
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much early on, but from the looks of things seems like a lot of code moved from v0.
tests would be awesome here as well 😃
PR is ready. But there are some performance issues that seem to be due to using V1 FlashAttention:
V1 FlashInfer (This PR):
V0 FlashInfer:
V0 FlashInfer with
There is a big performance degradation from using |
This pull request has merge conflicts that must be resolved before it can be |
Implement FlashInfer attention backend for V1.
Outstanding items that need feedback:
Need a better way to abstract out the AttentionMetadata creation interface, currently it just handles it case-by-case in the GPU runner for each attention backend.Solved after rebaseCascade attention seems to have different outputs from normal attention. Sometimes this difference is significant, but still coherent. Is this an expected behavior of cascade attention?Seems to match now after fixing a bugCurrent limitations: