[Bugfix][Frontend] Strip empty tool calls from incoming chat conversations #14054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Llama chat templates cannot handle an assistant message with the
tool_calls
field set but equal to an empty list. Most other chat templates just loop over thetool_calls
if there are any, but the Llama chat template asserts that if the field is present, the list's length is exactly 1. This causes an error when the list is given, but is empty.To resolve this issue, I just ignore the field when an "assistant" message has
len(tool_calls) == 0
. Also added a regression test to reproduce the issue and confirm the patch is successful.FIX #13978