Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Frontend] Strip empty tool calls from incoming chat conversations #14054

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

benchislett
Copy link
Contributor

@benchislett benchislett commented Feb 28, 2025

The Llama chat templates cannot handle an assistant message with the tool_calls field set but equal to an empty list. Most other chat templates just loop over the tool_calls if there are any, but the Llama chat template asserts that if the field is present, the list's length is exactly 1. This causes an error when the list is given, but is empty.

To resolve this issue, I just ignore the field when an "assistant" message has len(tool_calls) == 0. Also added a regression test to reproduce the issue and confirm the patch is successful.

FIX #13978

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Feb 28, 2025
@DarkLight1337
Copy link
Member

cc @K-Mistele

@DarkLight1337 DarkLight1337 requested a review from mgoin February 28, 2025 16:17
Copy link
Contributor

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Llama chat template cannot process tool_calls=[] in previous messages
3 participants