-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Explicitly include "omp.h" for MacOS to avoid installation failure #14051
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Sheng Yao <[email protected]>
8f7dc19
to
cb8c987
Compare
@realShengYao is this ready to be converted from draft? |
@hmellor yes yes |
Cool, could you merge from main (the failing test should be fixed already) and then I'll enable auto-merge |
Sure. Should be okay to auto merge now. |
Thanks again for the bugfix! |
You're most welcome! |
If we detect MacOS, explicitly include "omp.h". This helps to avoid the installation failure mentioned in #14034 .
FIX #14034