Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Explicitly include "omp.h" for MacOS to avoid installation failure #14051

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

realShengYao
Copy link

@realShengYao realShengYao commented Feb 28, 2025

If we detect MacOS, explicitly include "omp.h". This helps to avoid the installation failure mentioned in #14034 .

FIX #14034

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Sheng Yao <[email protected]>
@realShengYao realShengYao changed the title Explicitly include "omp.h" for MacOS to avoid installation failure [Bugfix] Explicitly include "omp.h" for MacOS to avoid installation failure Mar 1, 2025
@hmellor
Copy link
Member

hmellor commented Mar 2, 2025

@realShengYao is this ready to be converted from draft?

@realShengYao realShengYao marked this pull request as ready for review March 2, 2025 12:36
@realShengYao
Copy link
Author

@hmellor yes yes

@hmellor
Copy link
Member

hmellor commented Mar 2, 2025

Cool, could you merge from main (the failing test should be fixed already) and then I'll enable auto-merge

@realShengYao
Copy link
Author

Sure. Should be okay to auto merge now.

@hmellor hmellor enabled auto-merge (squash) March 2, 2025 15:33
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 2, 2025
@hmellor
Copy link
Member

hmellor commented Mar 2, 2025

Thanks again for the bugfix!

@realShengYao
Copy link
Author

You're most welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installation]: Can't find OpenMP headers on macOS
2 participants