Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Modify xgrammar version #14030

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shen-shanshan
Copy link
Contributor

@shen-shanshan shen-shanshan commented Feb 28, 2025

What this PR does

As mentioned in this PR (#13894), xgrammar have supported aarch64 system.

After my test, the result showed that guided decoding worker well with xgrammar on aarch64 system.

So we should modify the xgrammar version in requirement.txt after merging this PR (#13894).

Find more details about xgrammar v0.1.14.

Part of test logs:

Processed prompts: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:01<00:00,  1.49s/it, est. speed input: 7.41 toks/s, output: 1.35 toks/s]
Positive
WARNING 02-28 09:29:50 [__init__.py:33] xgrammar does not support regex guided decoding. Falling back to use outlines instead.
('Warning: torch.save with "_use_new_zipfile_serialization = False" is not recommended for npu tensor, which may bring unexpected errors and hopefully set "_use_new_zipfile_serialization = True"', 'if it is necessary to use this, please convert the npu tensor to cpu tensor for saving')
Processed prompts: 100%|█████████████████████████████████████████████████████████████████████████| 1/1 [00:04<00:00,  4.21s/it, est. speed input: 7.59 toks/s, output: 1.90 toks/s]
[email protected]

Signed-off-by: Shanshan Shen <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant