Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a note on full CI run in contributing guide #13646

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

terrytangyuan
Copy link
Contributor

This is based on my observation through the past PRs. Feel free to correct if I have missed anything or misunderstood the process.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 21, 2025
@DarkLight1337
Copy link
Member

I think this is unnecessary since it's also mentioned by the bot.

@terrytangyuan
Copy link
Contributor Author

terrytangyuan commented Feb 21, 2025

Oh thanks for pointing that out. I did not notice it. However, I think this is still nice to have this is the doc contributors would read even before submitting the PR. It's also in the spirit of making the process transparent as claimed in the doc:

We would like to make the review process transparent and efficient and make sure no contributor feels confused or frustrated

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@simon-mo simon-mo merged commit 8c0dd3d into vllm-project:main Feb 22, 2025
10 of 18 checks passed
@terrytangyuan terrytangyuan deleted the patch-3 branch February 22, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants