Bug fix: hpu mrope #167
Merged
Bug fix: hpu mrope #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
attafosu
commented
Sep 12, 2025
attafosu
commented
- HPU Mrope implementation had a bug which was exposed by [Bugfix] Fix platform-specific routing in CustomOp implementations vllm#24444
- Initial workaround was to use the default implementation: [BUGFIX] qwen2.5-vl failed after PR24444, provide a temp solution #162
- This PR fixes the bug in the HPU mrope
Signed-off-by: attafosu <[email protected]>
Signed-off-by: attafosu <[email protected]>
attafosu
requested review from
kzawora-intel,
xuechendi,
mswiniarsk and
adobrzyn
as code owners
|
Do we see performance improvement? |
xuechendi
reviewed
Sep 12, 2025
|
|
||
| key_rot = key[..., :self.rotary_dim] | ||
| key_pass = key[..., self.rotary_dim:] | ||
| key_rot = apply_rotary_pos_emb(key_rot, cos, sin, None, 0, rope_mode) |
There was a problem hiding this comment.
I did a comparison with existing forward_native, seems major difference is apply_rotary_pos_emb vs apply_rotary_emb_torch, may you check if we do gets perf gain with the oot impl, or we can use native ?
There was a problem hiding this comment.
Yeah, I did some quick tests and there's some perf gain over the default:
forward_native: 11.53 tok/sec
forward_oot: 12.32 tok/sec
This is on a smaller sized image and I expect it to be more pronounced on an even bigger input (text or image)
xuechendi
approved these changes
Sep 12, 2025
|
please fix pre-commit |
|
/run-gaudi-tests |
PatrykWo
pushed a commit
to PatrykWo/vllm-gaudi-vllm-docker
that referenced
this pull request
Sep 17, 2025
- HPU Mrope implementation had a bug which was exposed by vllm-project/vllm#24444 - Initial workaround was to use the default implementation: vllm-project#162 - This PR fixes the bug in the HPU mrope --------- Signed-off-by: attafosu <[email protected]> Co-authored-by: Chendi.Xue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.