Skip to content

Conversation

@kiscad
Copy link
Contributor

@kiscad kiscad commented Nov 27, 2025

What this PR does / why we need it?

The hccl_buffsize for EP process group is set by the _DEFAULT_BUFFER_SIZE, which is not enough for fused_moe kernel, especially for large max-num-batched-tokens. So we need to calculate the hccl_buffer for EP from the vllm_config.

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue with hccl_buffsize configuration by ensuring the HCCL_BUFFSIZE environment variable is respected when creating HCCL process group options. The changes look good, but I have a couple of suggestions. First, the logic for parsing the buffer size from the environment variable should be improved to handle non-positive values to prevent potential issues. Second, since the special handling for "mc2" communication groups was removed, adding a specific test case for this scenario would increase confidence that this change does not introduce any regressions.

@kiscad kiscad changed the title [bugfix] the problem of hccl_buffsize configuration. [bugfix] the hccl_buffsize configuration. Nov 28, 2025
@kiscad kiscad changed the title [bugfix] the hccl_buffsize configuration. [bugfix] the hccl_buffsize config for EP Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants