Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Nov 27, 2025

What this PR does / why we need it?

This patch aims to integrate the mooncake v0.3.7.2.post2 to vllm-ascend images

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Potabk Potabk requested review from wangxiyuan and wxsIcey November 27, 2025 12:09
@Potabk Potabk added ready read for review ready-for-test start test by label for PR labels Nov 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks changes from another branch to add support for building with Mooncake dependencies. This involves modifications to several Dockerfiles and the addition of a new installer script, tools/mooncake_installer.sh. The changes are mostly about setting up the build environment for Mooncake. I've found a high-severity issue in the new installer script related to incorrect error handling, which could lead to build failures with misleading error messages. My review comments provide suggestions to fix this.

@Potabk Potabk self-assigned this Nov 27, 2025
@wangxiyuan wangxiyuan merged commit 76d0ba4 into vllm-project:v0.11.0-dev Dec 1, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tools ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants