-
Notifications
You must be signed in to change notification settings - Fork 609
[Doc] Fix DeepSeek-V3.2-Exp doc, add docker command. #4479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: menogrey <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for DeepSeek-V3.2-Exp by adding explicit docker run commands for A3 and A2 series hardware. This is a good improvement for user experience, making the tutorial more self-contained. My review focuses on improving the readability and maintainability of these long docker commands. I've suggested a more concise way to specify the list of devices, which will reduce the potential for user error when copying the commands and make future maintenance easier.
| --device /dev/davinci0 \ | ||
| --device /dev/davinci1 \ | ||
| --device /dev/davinci2 \ | ||
| --device /dev/davinci3 \ | ||
| --device /dev/davinci4 \ | ||
| --device /dev/davinci5 \ | ||
| --device /dev/davinci6 \ | ||
| --device /dev/davinci7 \ | ||
| --device /dev/davinci8 \ | ||
| --device /dev/davinci9 \ | ||
| --device /dev/davinci10 \ | ||
| --device /dev/davinci11 \ | ||
| --device /dev/davinci12 \ | ||
| --device /dev/davinci13 \ | ||
| --device /dev/davinci14 \ | ||
| --device /dev/davinci15 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This long, repetitive list of --device flags is verbose and makes the command difficult to read. It's also prone to errors if a user is manually copying or editing it. You can make this command more concise, readable, and maintainable by generating the device flags programmatically using shell brace expansion. This reduces the chance of human error and makes it easier to adapt for configurations with a different number of devices in the future.
| --device /dev/davinci0 \ | |
| --device /dev/davinci1 \ | |
| --device /dev/davinci2 \ | |
| --device /dev/davinci3 \ | |
| --device /dev/davinci4 \ | |
| --device /dev/davinci5 \ | |
| --device /dev/davinci6 \ | |
| --device /dev/davinci7 \ | |
| --device /dev/davinci8 \ | |
| --device /dev/davinci9 \ | |
| --device /dev/davinci10 \ | |
| --device /dev/davinci11 \ | |
| --device /dev/davinci12 \ | |
| --device /dev/davinci13 \ | |
| --device /dev/davinci14 \ | |
| --device /dev/davinci15 \ | |
| $(printf -- '--device /dev/davinci%s ' {0..15}) \ |
| --device /dev/davinci0 \ | ||
| --device /dev/davinci1 \ | ||
| --device /dev/davinci2 \ | ||
| --device /dev/davinci3 \ | ||
| --device /dev/davinci4 \ | ||
| --device /dev/davinci5 \ | ||
| --device /dev/davinci6 \ | ||
| --device /dev/davinci7 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the A3 series configuration, this long list of --device flags can be simplified. Using shell features to generate the device list makes the command cleaner, less error-prone, and easier to maintain.
| --device /dev/davinci0 \ | |
| --device /dev/davinci1 \ | |
| --device /dev/davinci2 \ | |
| --device /dev/davinci3 \ | |
| --device /dev/davinci4 \ | |
| --device /dev/davinci5 \ | |
| --device /dev/davinci6 \ | |
| --device /dev/davinci7 \ | |
| $(printf -- '--device /dev/davinci%s ' {0..7}) \ |
What this PR does / why we need it?
Fix DeepSeek-V3.2-Exp doc, add docker command.
Does this PR introduce any user-facing change?
How was this patch tested?