Skip to content

Conversation

davidgao7
Copy link
Contributor

@davidgao7 davidgao7 commented Sep 7, 2025

The tutorial was using --static-model-types "transcription" but the actual implementation requires --static-model-labels "transcription" for proper routing of transcription requests.

This fixes the documentation mismatch where the tutorial didn't align with the actual code implementation in the routing logic.

When I implement transcription API I don't know how to get router print debug log; I tested to see if the debug logging work
Screenshot 2025-09-07 at 12 33 47 PM

FILL IN THE PR DESCRIPTION HERE

Mentioned here #469 (comment) (link existing issues this PR will resolve)

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

The tutorial was using --static-model-types "transcription" but the
actual implementation requires --static-model-labels "transcription"
for proper routing of transcription requests.

This fixes the documentation mismatch where the tutorial didn't align
with the actual code implementation in the routing logic.

Signed-off-by: David Gao <[email protected]>
@davidgao7 davidgao7 changed the title Docs/transcription api model labels [Docs] Correct parameter in transcription API tutorial Sep 7, 2025
@davidgao7 davidgao7 marked this pull request as ready for review September 7, 2025 05:33
@max-wittig
Copy link
Contributor

I think this should actually use static-model-types and not static-model-labels as this is meant for the LM-Cache.

@davidgao7 davidgao7 marked this pull request as draft September 7, 2025 11:48
@davidgao7
Copy link
Contributor Author

I think this should actually use static-model-types and not static-model-labels as this is meant for the LM-Cache.

Thanks for the reply, Max!

I see, so I should update the code to use --static-model-types instead of --static-model-labels. I'm not very familiar with the LM-Cache part of the codebase - could you briefly explain where static-model-labels is used there? Just a quick pointer would help me understand the distinction better, and I can check the details myself.

I'll update both the code and documentation to use static-model-types for this PR.

@max-wittig
Copy link
Contributor

@davidgao7 There is another issue. I will take care of it here: #681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants