[Misc] Refract the structure of VLLMRuntime CRD #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
…vllm-project-main
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
…account instead of hardcoding Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
YuhanLiu11
reviewed
Jun 7, 2025
| @@ -5,5 +5,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
| images: | |||
| - name: controller | |||
| newName: lmcache/operator | |||
| newName: 1nfinity/production-stack-controller | |||
There was a problem hiding this comment.
Please change this to lmcache docker hub image
operator/config/default.yaml
Outdated
| - --health-probe-bind-address=:8081 | ||
| command: | ||
| - /manager | ||
| image: 1nfinity/production-stack-controller:latest |
There was a problem hiding this comment.
Also push this to lmcache docker hub
Signed-off-by: royyhuang <[email protected]>
Signed-off-by: royyhuang <[email protected]>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
JustinDuy
pushed a commit
to JustinDuy/production-stack-1
that referenced
this pull request
Jun 13, 2025
* add CRD support for production stack Signed-off-by: royyhuang <[email protected]> * move opertor to a secondary dir instead of in root dir Signed-off-by: royyhuang <[email protected]> * rename api group from serving.vllm.ai to production-stack.vllm.ai Signed-off-by: royyhuang <[email protected]> * enable lmcache cpu offloading Signed-off-by: royyhuang <[email protected]> * enable lmcache remote cache server offloading Signed-off-by: royyhuang <[email protected]> * fix service discorvery issue by adding readiness probe to vllm pod Signed-off-by: royyhuang <[email protected]> * fix readiness probe Signed-off-by: royyhuang <[email protected]> * restructure runtime crd spec Signed-off-by: royyhuang <[email protected]> * add default operator manifest Signed-off-by: royyhuang <[email protected]> * move rbac for vllm-router pod to controller Signed-off-by: royyhuang <[email protected]> * use service account name defined in vllm-router cr to create service account instead of hardcoding Signed-off-by: royyhuang <[email protected]> * update sample loraadapter manifest Signed-off-by: royyhuang <[email protected]> * update default controller image Signed-off-by: royyhuang <[email protected]> * remove old image name patch Signed-off-by: royyhuang <[email protected]> --------- Signed-off-by: royyhuang <[email protected]>
davidgao7
pushed a commit
to davidgao7/production-stack
that referenced
this pull request
Jun 26, 2025
* add CRD support for production stack Signed-off-by: royyhuang <[email protected]> * move opertor to a secondary dir instead of in root dir Signed-off-by: royyhuang <[email protected]> * rename api group from serving.vllm.ai to production-stack.vllm.ai Signed-off-by: royyhuang <[email protected]> * enable lmcache cpu offloading Signed-off-by: royyhuang <[email protected]> * enable lmcache remote cache server offloading Signed-off-by: royyhuang <[email protected]> * fix service discorvery issue by adding readiness probe to vllm pod Signed-off-by: royyhuang <[email protected]> * fix readiness probe Signed-off-by: royyhuang <[email protected]> * restructure runtime crd spec Signed-off-by: royyhuang <[email protected]> * add default operator manifest Signed-off-by: royyhuang <[email protected]> * move rbac for vllm-router pod to controller Signed-off-by: royyhuang <[email protected]> * use service account name defined in vllm-router cr to create service account instead of hardcoding Signed-off-by: royyhuang <[email protected]> * update sample loraadapter manifest Signed-off-by: royyhuang <[email protected]> * update default controller image Signed-off-by: royyhuang <[email protected]> * remove old image name patch Signed-off-by: royyhuang <[email protected]> --------- Signed-off-by: royyhuang <[email protected]> Signed-off-by: David Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure the VLLMRuntime CRD. Now the each option has to belong to one of the following struct,
ModelSpec,VLLMConfig,LMCacheConfig,DeploymentConfig. This make sure we don't dump all kinds the options under VLLMRuntimeSpec and keep a clean structure of it.LoraAdapter spec has also be updated to avoid naming conflict, specifically
deploymentSpecrenamed toLoraAdapterDeploymentSpec.I also added a
config/default.yamlbuilt bykustomize.BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.