[wip] Add a new endpoint /sqldump, exporting the data for the current modules #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
changed the title
thecodrr
reviewed
Feb 5, 2020
main.v
Outdated
| @@ -56,6 +57,11 @@ pub fn (app mut App) new() { | |||
| $vweb.html() | |||
| } | |||
|
|
|||
| pub fn (app mut App) sqldump() { | |||
| sql := os.exec('pg_dump vpm --table=modules --no-password --username=admin') or { return } | |||
There was a problem hiding this comment.
As useful as this is, what if the user's db is not named vpm?
There was a problem hiding this comment.
It is already hardcoded in main.v . We can change it here and there to make it use env variables?
There was a problem hiding this comment.
Yes, that would be much better.
thecodrr
approved these changes
Feb 5, 2020
|
On my PC, it now shows something like this: |
thecodrr
requested changes
Feb 5, 2020
spytheman
changed the title
|
@spytheman is this still valid or should be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables easier onboarding of contributors (they can test their
changes locally using real data).
[wip] It also adds a README with a short description about what you need to do to start working on the vpm codebase locally.