Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regex: allow storing Regex fields in user structures, my making it public (fix #13) #14

Merged
merged 3 commits into from
Jan 16, 2025
Merged

regex: allow storing Regex fields in user structures, my making it public (fix #13) #14

merged 3 commits into from
Jan 16, 2025
+3 −2

Conversation

quaesitor-scientiam
Copy link

@quaesitor-scientiam quaesitor-scientiam commented Jan 16, 2025 •
edited by spytheman
Loading

Fix #13 .

Allow storing Regex fields in user structures.

@PythonWillRule
For github issue vlang#13
Loading
Loading status checks…
d3c0390
@PythonWillRule
For github issue vlang#13
Loading
Loading status checks…
3c80e18 
Fixed vmod
spytheman
spytheman approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@JalonSolov
Copy link
Contributor

JalonSolov commented Jan 16, 2025 •
edited
Loading

Wants a linefeed at the end of the v.mod file.

@spytheman
Copy link
Member

Wants a linefeed at the end of the v.mod file.

Afaik our parser does not need it, but it may be better looking with it, when printed.

@PythonWillRule
Fixed linefeed issue
Loading
Loading status checks…
78f73c1
@quaesitor-scientiam quaesitor-scientiam changed the title For github issue #13 Make struct Regex public Jan 16, 2025
@spytheman spytheman changed the title Make struct Regex public regex: Allow storing Regex fields in user structures (fix #13) Jan 16, 2025
@spytheman spytheman changed the title regex: Allow storing Regex fields in user structures (fix #13) regex: Allow storing Regex fields in user structures, my making it public (fix #13) Jan 16, 2025
@spytheman spytheman changed the title regex: Allow storing Regex fields in user structures, my making it public (fix #13) regex: allow storing Regex fields in user structures, my making it public (fix #13) Jan 16, 2025
@spytheman spytheman merged commit 9aec648 into vlang:master Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make struct Regex public
4 participants
@quaesitor-scientiam @JalonSolov @spytheman @PythonWillRule