fix: resolve multiple workflow issues (#737, #738, #740, #741) - #805
Open
teefeh-07 wants to merge 1 commit into
Open
fix: resolve multiple workflow issues (#737, #738, #740, #741)#805teefeh-07 wants to merge 1 commit into
teefeh-07 wants to merge 1 commit into
Conversation
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
|
@teefeh-07 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
This PR introduces several important improvements to our GitHub Actions workflows to enhance security, prevent race conditions, and increase reliability. It resolves multiple active issues surrounding workflow concurrency and dependency immutability.
📋 Tasks & Fixes Made
1. Secured Vercel Action Dependency (Fixes #737)
preview-deploy.ymlpreviously usedamondnet/vercel-action@v25, a mutable major-version tag. This is a security risk as the underlying action code could change unexpectedly without our explicit approval.@v25with its full immutable commit SHA (16e87c0a08142b0d0d33b76aeaf20823c381b9b9).2. Prevented Concurrent Semantic Releases (Fixes #738)
release.ymltriggers viaworkflow_runonmaincompletions without a concurrency group. Two quick merges could trigger overlappingsemantic-releaseinvocations, causing duplicate git tags and conflicting CHANGELOG commits.concurrencygroup scoped to the workflow and branch (release-${{ github.ref }}) withcancel-in-progress: false.3. Prevented Conflicting Rollback Drills (Fixes #740)
rollback-drill.ymlexecutes on a monthly schedule and manual dispatch without concurrency bounds. Since it submits real on-chain rollback transactions to the testnet, concurrent runs could corrupt contract state.concurrencygroup withcancel-in-progress: false.4. Bound Rollback Drill Execution Time (Fixes #741)
rollback-drill.ymlpolls the Stellar testnet for transaction confirmation but lacked atimeout-minutesbound, risking indefinite hangs if network issues occur.timeout-minutes: 15limit on therollback-drilljob.🔗 Related Issues
🛠️ Verification
amondnet/vercel-actionSHA corresponds tov25.cancel-in-progressis set tofalsefor queuing rather than cancellation.timeout-minutes: 15applies to the rollback drill.Closes #737
Closes #738
Closes #740
Closes #741