Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RelationalBone add getDefaultValue #1172

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ArneGudermann
Copy link
Contributor

Fix for #1152

@ArneGudermann ArneGudermann added the Priority: Medium This issue may be useful, and needs some attention. label May 24, 2024
@ArneGudermann ArneGudermann added this to the ViUR-core v3.7 milestone May 24, 2024
@ArneGudermann ArneGudermann marked this pull request as ready for review May 24, 2024 10:02
@@ -1309,6 +1309,27 @@ def getUniquePropertyIndexValues(self, valuesCache: dict, name: str) -> list[str
elif isinstance(value, list):
return self._hashValueForUniquePropertyIndex([x["dest"]["key"] for x in value])

def getDefaultValue(self, skeletonInstance):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about multilang?

@sveneberth sveneberth marked this pull request as draft May 24, 2024 14:35
@sveneberth sveneberth added the waiting-for-changes Waiting for changes/rework from the author label May 24, 2024
@ArneGudermann
Copy link
Contributor Author

@phorward
Should I wait for #1154 ?

@phorward
Copy link
Member

@phorward Should I wait for #1154 ?

well, #1154 can't be resolved with a huger redesign. I'm quite unsure about this, as we might refactor the entire bone logic, regarding multiple and language setting. As #1154 focuses the same problem, please keep this PR for now as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be useful, and needs some attention. waiting-for-changes Waiting for changes/rework from the author
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants