-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: enable site wide search #1370
Conversation
Signed-off-by: thisisobate <[email protected]>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@thisisobate Thanks for the quick turnaround on this! On the preview deploy, olap pages are now being found, as are pages with init_db_name_override. @FancyFane PTAL at https://deploy-preview-1370--vitess.netlify.app/ @thisisobate I have a UX nit. Now that the index holds all the content the search functionality has more work to do and there is lag between starting the search and providing the result. Let's have the search event handler immediately display a spinner animation so that as soon as the search starts, the end-user gets immediate feedback that a search is taking place. What do you think? Doable? |
Is this something we can do in a follow up PR? If the UX update is more than a day's effort, maybe we get the functionality in first and then work to smooth out the UX experience. |
@RobertKielty The search functionality seemed considerably better at including some of those pages that were previously not being included now in that preview URL so from my end I am seeing an improvement compared to before! |
I agree with you @nate-double-u Let's tackle this in a follow-up PR. |
Also providing feedback, the search functionality is now much better. Doing the search for |
Let's merge this in as is then, and we can open up a follow up issue. |
Thank you @RobertKielty @thisisobate for fixing this! Looking forward to the UX improvement PR 😛 |
Issue
Lunr depends on whatever we give it as the index to function. In the case of Vitess, we only crawl the summary of each of the docs pages. The summary is usually the first 5 or more sentences of a page hence the rest of the page/doc is not in the index.
Solution
To solve this issue, I created a new field containing all the page contents. This enables a complete site-wide search for content in Vitess.io
Future Improvements
To make the vitess.io search better, we need to improve two things:
Action Item
Fixes #1355