Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: print port in the logged error message after failed WS connection with EADDRINUSE #19212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: print port in the logged error message after failed WS connection with EADDRINUSE #19212

wants to merge 1 commit into from
+6 −4

Conversation

Andarist
Copy link
Contributor

Description

This is just a small QoL improvement, following the same error message as the one reported here:

vite/packages/vite/src/node/http.ts

Line 160 in 4f5845a

reject(new Error(`Port ${port} is already in use`))

@Andarist Andarist changed the title Print port in the logged error message after failed WS connection with EADDRINUSE chore(vite): print port in the logged error message after failed WS connection with EADDRINUSE Jan 16, 2025
@patak-dev patak-dev changed the title chore(vite): print port in the logged error message after failed WS connection with EADDRINUSE feat: print port in the logged error message after failed WS connection with EADDRINUSE Jan 16, 2025
@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andarist @patak-dev