Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue-jsx): replace export default defineComponent with babel (fix #345) #348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OMGVecchio
Copy link

Description

if (hasDefault && (needHmr || ssr)) {
  result.code =
    result.code!.replace(
      /export default defineComponent/g,
      `const __default__ = defineComponent`,
    ) + `\nexport default __default__`
}

The code above will compile const str = 'export default defineComponent' unexpectedly in the development environment

We can achieve the same task with babel

Additional context

issue #345

reproduction https://stackblitz.com/edit/vitejs-vite-rgsvev?file=src%2FApp.tsx

resolution https://stackblitz.com/~/github.com/OMGVecchio/vite-plugin-vue?file=demo/ExportDefault.jsx


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant