feat: rolldown vite full bundle mode #107

underfin · 2025-04-09T09:52:20Z

Current status

Rolldown vite already integrated rolldown at dev build, could using npx vite --fullBundleMode to preview it. It only used at client build, the ssr is not supported at now.

integrated HMR features

propagate to root
self accept
accept deps
import.hot.invalidate
(wip) import.hot.acceptExports
(pending) CSS hmr
(new) support load module exports by import.meta.hot.getExports(), react plugin ref

Plugins

(wip) react plugin

Test status

define
hmr-root
(wip) hmr

Break changes

The xxx.html could be seen at original vite dev, but not added it to build.rollupOptions.input. In full bundle mode, you need to add the build.rollupOptions.input to make sure the HTML could be seen.rolldown vite test ref
The xxx.js could be seen at original vite dev, but it can't at full bundle mode.react plugin test ref
The html transformIndexHtml default order is post, it will inject some code to HTML, if it need to import module, it can't work at full bundle mode. The injected code need to bundled, you need to set the order to pre. react plugin ref

Break changes but could be improved

The implicit feature with soft invalidate, it make sure the transform hook is called once at original vite. In full bundle mode, it should be once, but not implement at now, we could improve it at future. rolldown vite test ref
The html transformIndexHtml is running at build, the config.server is invalid. react plugin ref

pkg-pr-new · 2025-04-21T08:37:37Z

Open in StackBlitz

npm i https://pkg.pr.new/vitejs/rolldown-vite@107

commit: bfb953f

underfin · 2025-04-21T10:11:14Z

packages/vite/src/node/__tests__/plugins/import.spec.ts

-        '\t...typeof m === "object" && !Array.isArray(m) || typeof m === "function" ? m : {},\n' +
-        '\tdefault: m\n' +
-        '})(__vite__cjsImport0_react)',
+        'const react = ((m) => m?.__esModule ? m : { ...typeof m === "object" && !Array.isArray(m) || typeof m === "function" ? m : {}, default: m })(__vite__cjsImport0_react)',


It is wired for it coudle be success at rolldown-vite branch.

It's probably caused by the "vitest>vite" overrides. Vitest uses Vite to process the files and that changes the Function::toString result.

sapphi-red · 2025-04-22T02:05:49Z

packages/vite/src/client/client.ts

+    function importModuleWithFullBundleMode() {
+      const importPromise = import(base + url)
+      return importPromise.then(() =>
+        // @ts-expect-error globalThis.__rolldown_runtime__


In the future, I think it's good to have the types exposed from rolldown so that we can use it like:

declare var __rolldown_runtime__: RolldownHmrRuntime

packages/vite/src/client/hmrModuleRunner.ts

sapphi-red · 2025-04-22T02:20:04Z

packages/vite/src/node/__tests__/plugins/import.spec.ts

-        '\t...typeof m === "object" && !Array.isArray(m) || typeof m === "function" ? m : {},\n' +
-        '\tdefault: m\n' +
-        '})(__vite__cjsImport0_react)',
+        'const react = ((m) => m?.__esModule ? m : { ...typeof m === "object" && !Array.isArray(m) || typeof m === "function" ? m : {}, default: m })(__vite__cjsImport0_react)',


It's probably caused by the "vitest>vite" overrides. Vitest uses Vite to process the files and that changes the Function::toString result.

packages/vite/src/node/build.ts

sapphi-red · 2025-04-22T02:42:07Z

packages/vite/src/node/cli.ts

+        if (!server.httpServer) {
+          throw new Error('HTTP server not available')
+        }


We should probably support middleware mode (it does not have server.httpServer) in the future.

packages/vite/src/node/plugins/clientInjections.ts

packages/vite/src/node/server/index.ts

sapphi-red · 2025-05-27T04:01:15Z

packages/vite/src/node/idResolver.ts

-                  isBuild: config.command === 'build',
+                  isBuild,


Shouldn't this be instead? Does it actually need to set isBuild: false? If so, why?

isBuild: config.command === 'build', optimizeDeps: false,

The full bundle mode also is build, here only add a condition with config.command === 'build' || experimental.fullBundleMode. The production mode maybe could be removed.
Here need to ensure consistency with build.

sapphi-red · 2025-05-27T04:58:36Z

packages/vite/src/node/build.ts

+    treeshake: experimental.fullBundleMode
+      ? false
+      : options.rollupOptions.treeshake,


Why does this have to be false?

The treeshake will remove unused code, but the unused code maybe using at hmr.

underfin marked this pull request as draft April 9, 2025 09:52

underfin force-pushed the rolldown-vite-full-bundle-mode branch from f46540b to 744fe8b Compare April 15, 2025 08:12

antfu mentioned this pull request Apr 17, 2025

[Feature Request][DevTools]: EPIC rolldown/rolldown#4145

Open

12 tasks

underfin added the trigger: preview label Apr 21, 2025

underfin force-pushed the rolldown-vite-full-bundle-mode branch from c580d0c to 191a670 Compare April 21, 2025 08:33

underfin changed the title ~~wip: rolldown vite full bundle mode~~ feat: rolldown vite full bundle mode Apr 21, 2025

underfin commented Apr 21, 2025

View reviewed changes

underfin marked this pull request as ready for review April 21, 2025 10:14

underfin marked this pull request as draft April 22, 2025 02:21

sapphi-red reviewed Apr 22, 2025

View reviewed changes

underfin force-pushed the rolldown-vite-full-bundle-mode branch 2 times, most recently from 657dbc6 to e44af73 Compare April 29, 2025 08:56

sapphi-red force-pushed the rolldown-vite branch from 1d5030a to 24787ef Compare April 30, 2025 06:30

underfin force-pushed the rolldown-vite-full-bundle-mode branch from 635f53f to 5d68ea9 Compare May 7, 2025 07:32

This comment was marked as off-topic.

Sign in to view

underfin force-pushed the rolldown-vite-full-bundle-mode branch from 79e2b43 to 6593719 Compare May 14, 2025 06:42

underfin added 12 commits May 19, 2025 16:36

feat: rolldown full bundle mode

0d4d6c0

feat: make memory files middleware work

25f3e0e

fix: make js define plugin works at dev build

f183472

fix: disable rolldown minify at devlopment build

c57d182

fix: make watcher + rolldown hmr build work

2bbb201

chore: disable ws validate connnection

cf9e3cc

chore: disable dev plugin relate logic

6390882

chore: enable loadfallback plugin at dev build

804a636

chore: disable depOptimizer

809c553

fix: set correct header for memory files

2715861

chore: make test work, avoid overrides vitest vite

bba3e73

chore: avoid watcher outdir

0a5a51a

underfin added 19 commits May 19, 2025 16:39

fix: ignored hmr soft invalidate

28ad636

fix: invalidate in circular dep

c404332

chore: disable not entry html hmr test and css hmr test

6d4a115

chore: skip rolldown hmr for outside module graph

4d51f1d

chore: fix lint

955a7ab

fix: disable treeshake becasue the minify is disabled

930092e

fix: htmlFallbackMiddleware should check fullBundleMode memoryFiles

7976768

fix: patch rolldown module runner changes

09e498e

feat: add hmr hot getExports

bac444e

chore: patch rolldown module runner changes

7ade2bc

chore: run hmr at first

eb361ca

feat: debounce reBuild

467b118

chore: using await bundle.watchFiles

bd44ee2

chore: add hmr html files to rollupOptions.input

950428b

fix: react plugin get module exports

9c7f704

feat: add build moduleGraph

80f53db

feat: make sourcemap work at full bundle mode dev

acd2c41

chore: disable BuildModuleGraph

f03bc47

chore: rebase

bdb70a9

underfin force-pushed the rolldown-vite-full-bundle-mode branch from 9265346 to bdb70a9 Compare May 19, 2025 08:41

underfin added trigger: preview and removed trigger: preview labels May 19, 2025

underfin added 5 commits May 20, 2025 14:33

fix: aovid build oxc pluin enable jsx option

f7dc0b7

fix: eanble native nativeModulePreloadPolyfillPlugin

9f56cb8

chore: fix fmt

01090e0

fix: add cwd to hmr test

a28f815

chore: add test-full-bundle-mode in ci

bfb953f

underfin force-pushed the rolldown-vite-full-bundle-mode branch from 2fc1ba0 to bfb953f Compare May 26, 2025 10:06

sapphi-red reviewed May 27, 2025

View reviewed changes

Uh oh!

feat: rolldown vite full bundle mode #107

Are you sure you want to change the base?

feat: rolldown vite full bundle mode #107

Uh oh!

Conversation

underfin commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current status

integrated HMR features

Plugins

Test status

Break changes

Break changes but could be improved

Uh oh!

pkg-pr-new bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

underfin commented Apr 9, 2025 •

edited

Loading

pkg-pr-new bot commented Apr 21, 2025 •

edited

Loading